Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search trigger to work on every input change #2935

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Dec 20, 2024

Description:

This PR updates the search functionality in the overview.component.html by modifying the event that triggers the search action when the user types in the ion-searchbar.

Changes:

  • Replaced the (ionChange) event with the (input) event on the ion-searchbar.
  • This change ensures that the searchOnChange() method is called immediately when the input value changes, allowing the search to trigger as the user types, rather than only after pressing enter or losing focus.

Reason for Change:

  • The (ionChange) event would only fire when the input field loses focus or the user presses the Enter key. This made the search feel unresponsive for real-time input. By using (input), the search updates dynamically with every keystroke.

Impact:

  • This change enhances the user experience by providing immediate feedback on search input.
  • It ensures a more responsive and seamless interaction with the search bar.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2935      +/-   ##
=============================================
+ Coverage      56.63%   56.63%   +0.01%     
- Complexity      9513     9514       +1     
=============================================
  Files           2253     2253              
  Lines          96074    96074              
  Branches        7095     7095              
=============================================
+ Hits           54401    54402       +1     
+ Misses         39666    39662       -4     
- Partials        2007     2010       +3     

@Sn0w3y Sn0w3y changed the title Fix Search gets only Fired when "Enter" is pressed Fix search trigger to work on every input change Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant