Websocket: WSS instead of WS if page is accessed via HTTPS

[helgeklein]

Prevents mixed content errors in the browser by selecting WSS or WS for the websocket depending on the page's scheme (HTTPS or HTTP).

This fixes the problem described in issue 2396.

[sfeilmeier]

Thanks!

[helgeklein]

Hi @sfeilmeier, I just upgraded my FEMS system to version 2025.1.2 but this fix is not being used. Instead, the backend URL is still built statically with unencryted WS:// only:

url: 'ws://' + location.hostname + (location.port ? ':' + location.port : '') + '/websocket'

[Sn0w3y]

Hi @sfeilmeier, I just upgraded my FEMS system to version 2025.1.2 but this fix is not being used. Instead, the backend URL is still built statically with unencryted WS:// only:

url: 'ws://' + location.hostname + (location.port ? ':' + location.port : '') + '/websocket'

Are you sure it is using ws:// to Backend?

This is from my FEMS and i guess it is either local EDGE to UI or the config does not reflect the wss:// to Fenecon.

[clehne]

Hi @Sn0w3y, I think WS is the preferred way here. WSS is added via e.g. nginx proxy functionality. This has several advantages, e.g. minimisation of attack surface, more up to date security fixes. Easier certificate handing,...

[Sn0w3y]

Hi @clehne - this is just a Snippet (Screenshot) from a FEMS we have in our Account :D

[sfeilmeier]

@helgeklein: OpenEMS UI uses themes for different production stylings. OpenEMS only has ui/src/themes/openems/environments/*.ts files; additionally every distributor of an OpenEMS based EMS adds an individual theme with his own URLs.

[helgeklein]

@Sn0w3y The ctrlBackend0 setting of my Fenecon device shows the same WSS URL as on your screenshot: wss://www1.fenecon.de:443/openems-backend2.

However, my issue (and fix) are about something different: they're about how the JavaScript code in the browser talks to the Fenecon device in my house. And that latter communication is still happening unencrypted via WS.

[helgeklein]

@helgeklein: OpenEMS UI uses themes for different production stylings. OpenEMS only has ui/src/themes/openems/environments/*.ts files; additionally every distributor of an OpenEMS based EMS adds an individual theme with his own URLs.

Thanks, @sfeilmeier. How can the URL template be changed in the theme used by Fenecon?

[helgeklein]

Hi @sfeilmeier, will the Fenecon theme be updated to include this change?