Release 4.1.7 spams MQTT with non-stop evse/claim: {"state":"null"} messages many times per second

[rigorka]

Steps to reproduce:

• Initially I had 4.0.0 installed, upgraded that via the web UI to 4.1.7. However I can also confirm that building the fw from the current master git branch and installing it to a freshly unpacked ESP32 produces the same results.
• My MQTT handler has collapsed immediately overloaded by hundreds of evse/claim: {"state":"null"} messages.
• I've tried Factory Reset which did not fix the situation
• Making and then releasing a Claim via HTTP API fixes the problem until the next reboot
• After rebooting the Openevse Wifi it spams the MQTT queue again

Downgrading to release 4.1.6 fixes the problem.

[glynhudson]

@KipK could this be related to #488 ?

[KipK]

Mhhh I don't think so. I'm jumping in a plane right now but will get a look tomorrow.
I haven't saw such behavior here, but there's definitely something wrong I have to track down.

[KipK]

Ok I've found it's prolly there:
https://github.com/OpenEVSE/ESP32_WiFi_V4.x/blob/65ca1bc4a877eb618a3c44be11019481dd75d11c/src/mqtt.cpp#L501

I'll fix that

[KipK]

@rigorka , I can't reproduce any spamming here. Could you post here the result of http://openevse.local/claims/ and http://openevse.local/claims/target while it's happening ?

Thanks

edit: openevse publish in /claim topic only when claims_version change or at bootup. So if it spams mqtt server, it probably means there's something calling lot of claims somewhere else ( but OpeEvse only publish in /claim topic claims coming from mqtt service. It publish "state" = "null" then but there's probably something else publishing a claim with high frequ I'd like to spot on your config.

[KipK]

Forget it, I've found. I forgot to inialise claims_version ...
Fix is coming

[KipK]

It stills not fixed I can see the debug log with mqtt activated spaming claims has changed, posting claims. I'm looking at it.