Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #39

Open
chrwm opened this issue Dec 13, 2022 · 4 comments
Open

Update requirements.txt #39

chrwm opened this issue Dec 13, 2022 · 4 comments
Assignees

Comments

@chrwm
Copy link
Member

chrwm commented Dec 13, 2022

When cloning the repo and creating and environment for development purposes from requirements.txt, I stumbled upon requirement problems for pandas and sqlalchemy while testing code.

@jh-RLI is it fair to fix both package versions to pandas==1.2.4, sqlalchemy==1.3.16 as noted here or does anything speaks against it? If only the latter is possible then a dev note would be nice.

@chrwm chrwm self-assigned this Dec 13, 2022
@jh-RLI
Copy link
Collaborator

jh-RLI commented Dec 13, 2022

sure you can update this in the requirements.txt.
Maybe we should use a =< instead of == to make it less strict but thats not relevant for now. I will take another debug tour to finally fix the oedialect and remove this restriction next year :)

@chrwm
Copy link
Member Author

chrwm commented Dec 13, 2022

One thing I just noticed is that in the tutorial sqlalchemy==1.3.16 is specified and in setup.py (and actually installed when oem2orm is installed) sqlalchemy==1.3.14 is specified.
I am currently editing also the tutorial and could change it, if is wrong there.

@jh-RLI
Copy link
Collaborator

jh-RLI commented Dec 13, 2022

I think 1.3.24 or .22 is the Last version That is supported. If you can confirm that then we shuld include it.

@christian-rli
Copy link

christian-rli commented Feb 16, 2023

This issue remains and I just ran into it. Just to let you know ;)
Also, I believe it needs to be updated in the setup.py as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants