Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oem2orm upload tutorial #156

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Improve oem2orm upload tutorial #156

merged 2 commits into from
Jan 5, 2023

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Dec 13, 2022

Closes #155

  • implement table upload in chunks to ensure stable OEP connection

@chrwm chrwm added the enhancement New feature or request label Dec 13, 2022
@chrwm chrwm self-assigned this Dec 13, 2022
@chrwm chrwm mentioned this pull request Dec 13, 2022
Open
@chrwm chrwm marked this pull request as ready for review January 4, 2023 16:03
@chrwm
Copy link
Member Author

chrwm commented Jan 4, 2023

A the function to upload multiple tables in a folder to the OEP can be added in another tutorial or another PR on this tutorial in the future. Ready for review.

@chrwm chrwm requested a review from jh-RLI January 4, 2023 16:03
jh-RLI
jh-RLI reviewed Jan 4, 2023
View reviewed changes
upload/OEP_Upload_Process_Data_and_Metadata_oem2orm.ipynb Outdated
" print('The program throws the following exception:')\n",
" print(e)\n",
" finally:\n",
" print(f'Take a lot at your table on the OEP: https://openenergy-platform.org/dataedit/view/{schema}/{table_name}')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot = look?

jh-RLI
jh-RLI approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the typo it looks fine :)

@chrwm chrwm merged commit 29d25e6 into develop Jan 5, 2023
@chrwm chrwm deleted the feature-155-improve-oem2orm-upload-tutorial branch January 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@chrwm chrwm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tutorial: OEP_Upload_Process_Data_and_Metadata_oem2orm.ipynb
2 participants
@chrwm @jh-RLI