Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make radiation a subclass of energy transfer #1031 #1447

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Make radiation a subclass of energy transfer #1031 #1447

merged 1 commit into from
Jan 16, 2023

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Jan 13, 2023

Summary of the discussion

Part of #1031: Make radiation a subclass of energy transfer

Type of change (CHANGELOG.md)

Updated

  • radiation

Workflow checklist

Automation

No automation

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Jan 13, 2023
carstenhoyerklick
carstenhoyerklick approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@carstenhoyerklick carstenhoyerklick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aggree to moving radiation

@carstenhoyerklick carstenhoyerklick merged commit b3fd924 into dev Jan 16, 2023
@stap-m stap-m deleted the feature-1031-make-radiation-subclassof-energytransfer branch October 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carstenhoyerklick carstenhoyerklick carstenhoyerklick approved these changes

@stap-m stap-m Awaiting requested review from stap-m

Assignees
No one assigned
Labels
oeo-physical changes the oeo-physical module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-emele @carstenhoyerklick