Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON Request #7

Closed
wants to merge 1 commit into from
Closed

Add support for JSON Request #7

wants to merge 1 commit into from

Conversation

dwamara
Copy link

@dwamara dwamara commented Sep 19, 2016

Sorry for the automatic reformatting. I just added a new method to support the sending of JSON Requests. I needed it myself for a project that I was doing so I thought it could be helpful. Too bad there is no work on the library at the moment as I would like to see how you get the Expose through the library.

@pinhead84
Copy link
Contributor

Hi dwamara,

thanks for your feedback. Unfortunately I can't merge your pull request right away because

  • the different code formatting would make it harder for others to track changes.
  • you've made your changes on the master branch. If you like to provide pull requests in the future, please use the develop branch instead as described in the contribution notes.

I just added a new method to support the sending of JSON Requests.

I've added your change to the develop branch and also made it work with the subprojects for Apache HttpComponents - see commit bba9b0d. This modification is already available through our snapshot repository as described in the wiki (version 0.4-SNAPSHOT).

Maybe it would also make sense to provide a JSON alternative for AbstractClient.sendXmlAttachmentRequest(). At least this would be necessary as soon as we're officially supporting JSON in our API implementations. We're going to investigate further, if full JSON support should be placed on our agenda.

Too bad there is no work on the library at the moment as I would like to see how you get the Expose through the library.

Further development of the library depends on the requirements of our customers and our applications. In our projects there is currently no need for an implementation of other API's than Import/Export.

But I've realized after a closer look at the documentations, that Exposé-API does not seem to be very complex. So I've made a first experimental implementation and pushed it into a separate feature/Expose-API branch. I wasn't able to test it yet - therefore I've decided to use a separate branch at the moment. Feel free to test and improve this implementation if you like. ;)

Please open a separate issue in case of questions or further discussions about Exposé-API.

@pinhead84 pinhead84 closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants