Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Error Regarding WaveDirMod #246

Closed
jjonkman opened this issue Feb 20, 2019 · 3 comments · Fixed by #357
Closed

Small Error Regarding WaveDirMod #246

jjonkman opened this issue Feb 20, 2019 · 3 comments · Fixed by #357

Comments

@jjonkman
Copy link
Collaborator

HydroDyn input parameter WaveDirMod is supposed to be used only when WaveMod=2, 3, or 4. However, the logic in routine HydroDyn_Input.f90/HydroDynInput_ProcessInitData() forces WaveMod to equal 0 if WaveDirMod == 1 and WaveMod <> 2, 3, or 4. Instead of setting WaveMod = 0, WaveMultiDir should be set to .FALSE. in this case.

This issue was reported in the following topic on the forum: https://wind.nrel.gov/forum/wind/viewtopic.php?f=4&t=2213.

@ebranlard
Copy link
Contributor

ebranlard commented Feb 20, 2019

The logic in the code is as follows:

WaveMultiDir = .FALSE.         ! Set flag to false to start
IF (WaveMod >= 2 .AND. WaveMod <= 4 .AND. WaveDirMod == 1 ) THEN
      WaveMultiDir = .TRUE.
ELSEIF ( (WaveMod < 2 .OR. WaveMod >4) .AND. WaveDirMod == 1 ) THEN
      CALL WARNING('WaveDirMod unused unless WaveMod == 2, 3, or 4.  Ignoring WaveDirMod.',)
      WaveMod   = 0
ENDIF

The last assignement should be:

 WaveDirMod   = 0

I'll submit a pull request if you agree

ebranlard added a commit to ebranlard/openfast that referenced this issue Feb 20, 2019
@jjonkman
Copy link
Collaborator Author

Actually, I think all you need to do is eliminate the last assignment (WaveMod = 0) altogether.

ebranlard added a commit to ebranlard/openfast that referenced this issue Feb 20, 2019
rafmudaf pushed a commit that referenced this issue Feb 21, 2019
* WaveMode was set to 0 instead of WaveDirMod (Fixes #246)
@rafmudaf
Copy link
Collaborator

Fixed by #247

ashesh2512 pushed a commit to ashesh2512/openfast that referenced this issue Mar 21, 2019
* WaveMode was set to 0 instead of WaveDirMod (Fixes OpenFAST#246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants