BeamDyn subroutine argument passing

[bjonkman]

While building the dev branch, today, my compiler warned

BeamDyn.f90(2673): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value. [RR0META]

The code looks a little unusual. The calling code
is sending m%qp%RR0mEta(:,idx_qp,nelem) as an intent(out) variable (which Fortran could fill with zeros or maybe random values?):

openfast/modules/beamdyn/src/BeamDyn.f90

Line 2675 in e85ee49

real(BDKi), intent(out) :: RR0mEta(:), rho(:,:)

But then instead of using the Calc_RR0mEta_rho() routine's argument, it sets that same portion of m%qp inside the routine

openfast/modules/beamdyn/src/BeamDyn.f90

Line 2679 in e85ee49

m%qp%RR0mEta(:,idx_qp,nelem) = MATMUL(RR0, p%qp%mEta(:,idx_qp,nelem))

This should be changed to either (1) use the routine's RR0META variable instead of m%qp%RR0mEta(:,idx_qp,nelem) or (2) remove the routine's RR0META variable

[andrew-platt]

Thanks for finding this. I agree this looks a bit unusual. I think we should go with solution (1) to be consistent with the rest of that routine. I'll put together a PR.

[andrew-platt]

Fixed with #2642