Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors building with MPT #522

Closed
jrood-nrel opened this issue Aug 9, 2020 · 0 comments · Fixed by #524
Closed

Errors building with MPT #522

jrood-nrel opened this issue Aug 9, 2020 · 0 comments · Fixed by #524
Assignees
@rafmudaf
Labels
Type: Bug

Comments

@jrood-nrel
Copy link
Collaborator

Bug description
When using MPT for the MPI implementation on Eagle, there appears to be an issue with the DOUBLE_PRECISION macro.

glue-codes/openfast-cpp/src/OpenFAST.cpp
<command-line>: error: expected unqualified-id before numeric constant
/opt/hpe/hpc/mpt/mpt-2.22/include/mpi++.h:1458:46: note: in expansion of macro 'DOUBLE_PRECISION'
 _MPIPP_EXTERN_ _MPIPP_STATIC_ const Datatype DOUBLE_PRECISION;
                                              ^~~~~~~~~~~~~~~~
sayerhs added a commit to sayerhs/OpenFAST that referenced this issue Aug 12, 2020
@sayerhs
Workaround DOUBLE_PRECISION macro when building with HPE MPT
a9997b3 
OpenFAST currently uses `DOUBLE_PRECISION` compile-time definition to activate double precision as default during build. This conflicts with the define in the MPI header file (for HPE MPT) when building the C++ API interface. This commit works around this issue by using `OPENFAST_DOUBLE_PRECISION` variable when building with CMake. The code checks for the original `DOUBLE_PRECISION` macro for backward compatibility. The VS build pathway is unaffected.

Fixes OpenFAST#522
@sayerhs sayerhs mentioned this issue Aug 12, 2020
Merged
@sayerhs sayerhs linked a pull request Aug 12, 2020 that will close this issue
Workaround DOUBLE_PRECISION macro when building with HPE MPT #524
Merged
rafmudaf pushed a commit that referenced this issue Aug 13, 2020
@sayerhs
Workaround DOUBLE_PRECISION macro when building with HPE MPT (#524)
f2517ec 
OpenFAST currently uses `DOUBLE_PRECISION` compile-time definition to activate double precision as default during build. This conflicts with the define in the MPI header file (for HPE MPT) when building the C++ API interface. This commit works around this issue by using `OPENFAST_DOUBLE_PRECISION` variable when building with CMake. The code checks for the original `DOUBLE_PRECISION` macro for backward compatibility. The VS build pathway is unaffected.

Fixes #522
@rafmudaf rafmudaf self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafmudaf rafmudaf

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround DOUBLE_PRECISION macro when building with HPE MPT sayerhs/OpenFAST
2 participants
@rafmudaf @jrood-nrel