Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Regression testing does not capture NaN's in output #711

Closed
andrew-platt opened this issue Apr 9, 2021 · 1 comment
Closed

Comments

@andrew-platt
Copy link
Collaborator

Bug description
The regression testing does not fail the test when NaN values exist in the test output files.

To Reproduce

  • checkout bbbfdc3 (dev branch head on April 9, 2021) and corresponding r-test
  • add flags -finit-real=inf -finit-integer=9999 to the gcc flags
  • compile hydrodyn_driver with gcc 10
  • Run hydrodyn driver regression test for the OC4Semi:
    • ctest -R hd_5MW_OC4Semi_WSt_WavesWN

The resulting <build_dir>/reg_tests/modules/hydrodyn/hd_5MW_OC4Semi_WSt_WavesWN/driver.HD.out will contain NaN in the columns for HydroMxi, HydroMyi, and HydroMzi but ctest will show the case as passing.

There is a bug in HydroDyn with uninitalized variables in the Morrison module that is causing this behavior. This will be addressed in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants