[BugFix] Raise an error if reg test results contain NaN or infinity #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
The regression test framework currently does not catch NaN's or Infinity in the test results since these are represented as floats in Numpy. This pull request adds an explicit check for any NaN or Infinity values in the results and throws an error is they are encountered.
Related issue, if one exists
#711
Impacted areas of the software
Test results, if applicable
The debug test is expected to fail, but it fails differently than in the previous commit. Whereas the previous commit failed as if the results were different, this one fails and notes that a NaN was encountered.