Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD: merge more of TwrInfl and TwrInflArray routines #1042

Merged
merged 8 commits into from
Sep 20, 2022

Conversation

bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Mar 14, 2022

Feature or improvement description
This PR merges more parts of the TwrInfl and TwrInflArray, which are basically two copies of the tower influence calculations, one for the BEMT module and the other for FVW.

This merge introduces a few changes to how the code checks that the tower influence should be applied:

  1. BEMT now turns off the tower influence if the tower clearance is more than 20 times the tower diameter.
  2. BEMT now turns off the tower influence if the tower clearance is less than 0.01 times the tower diameter.
  3. BEMT now limits the tower shadow influence to no more than -1/2 the wind speed at the tower.
  4. FVW now limits the tower shadow influence to no more than -1/2 the wind speed at the tower for all tower shadow models. It previously was applying this limit only to the Eames model.

Note: this PR also fixes an issue where there were some uninitialized variables in the FVW tower influence calculations if the tower clearance was > 20 TowerDiam or < 0.01 TowerDiam.

Impacted areas of the software
AeroDyn (AD15)

Test results, if applicable
Tests with any of the properties listed above may be affected. In general, we wouldn't expect those conditions to apply for normal BEMT simulations. However, the OpenFAST reg-test does have AOC models with tower-diameters of 0.06 m, so the new checks effectively turn off all tower influence calculations in those cases.

Make BEM and FVW routines calculate tower influence in the same way, without duplicating as much code.
@ebranlard ebranlard self-requested a review March 14, 2022 21:47
@andrew-platt andrew-platt added Approved: Update baselines Pull request is ready for updated regression test baselines Module: AeroDyn labels Mar 14, 2022
@rafmudaf rafmudaf modified the milestones: v3.4.0, v3.3.0 Sep 20, 2022
@rafmudaf rafmudaf merged commit 8bb1bc2 into OpenFAST:dev Sep 20, 2022
@bjonkman bjonkman deleted the f/AD_TwrShadow branch September 20, 2022 16:42
@rafmudaf rafmudaf mentioned this pull request Oct 27, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved: Update baselines Pull request is ready for updated regression test baselines Module: AeroDyn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants