Fix Time-Step Delay in Super Controller within FAST.Farm #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transfer within FAST.Farm of to_SC, which is an output from OpenFAST and an input to the super controller, previously happened after the call to the super controller CalcOutput, which caused a one time-step delay. This change moves the transfer before the call to super controller CalcOutput to eliminate the delay. The original implementation correctly followed the FAST.Farm glue code implementation plan, but it is unclear why the plan was written this way. The FAST.Farm user documentation in readthedocs is already consistent with this change, so, the implementation and user documentation are now consistent. This issue was discussed in Dec '21 on our forum: https://forums.nrel.gov/t/super-controller-link-with-turbine-controller/2587/19.
andrew-platt
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
The transfer within FAST.Farm of
to_SC, which is an output from OpenFAST and an input to the super controller, previously happened after the call to the super controllerCalcOutput, which caused a one time-step delay. This change moves the transfer before the call to super controllerCalcOutputto eliminate the delay. The original implementation correctly followed the FAST.Farm glue code implementation plan, but it is unclear why the plan was written this way. The FAST.Farm user documentation in readthedocs is already consistent with this change, so, the implementation and user documentation are now consistent.Related issue, if one exists
This issue was discussed in Dec '21 on our forum: https://forums.nrel.gov/t/super-controller-link-with-turbine-controller/2587/19.
Impacted areas of the software
FAST.Farm glue code
Additional supporting information
Test results, if applicable
The super controller is not currently tested.