Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD: increase max length of line read from kinematics files #1230

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

andrew-platt
Copy link
Collaborator

This PR is ready for merging

Description
If a user has a complex hydrodynamics model with lots of nodes and attempts to use WaveMod==6, the reading of the wave kinetic files may fail because there are more than 2048 characters on a line (see issue #1229). I increased the size of the temporary character array used to an absurdly large value (2^16 characters) so that this will no longer be a problem with more than ~100 nodes.

Test cases
No test cases are affected by this PR.

closes #1229

@andrew-platt andrew-platt self-assigned this Aug 25, 2022
bjonkman added a commit to bjonkman/openfast that referenced this pull request Aug 29, 2022
@andrew-platt andrew-platt merged commit b496e46 into OpenFAST:dev Aug 31, 2022
@andrew-platt andrew-platt deleted the b/HD_KinematicLongInputLine branch September 7, 2022 16:12
@rafmudaf rafmudaf mentioned this pull request Oct 27, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant