ED/AD: reactivating rotor furling and tailfin aerodynamics #1277
Conversation
There was a problem hiding this comment.
Thanks, @ebranlard. I'm excited to see tail fin aerodynamics and furling DOFs from FAST v7 re-introduced into OpenFAST! Please find my initial review comments. Overall I agree with the approach taken.
| The tail-furl bearing can be an ideal bearing with | ||
| no friction by setting ``TFrlMod`` to 0; by setting | ||
| ``TFrlMod`` to 1, it also has a standard model that | ||
| includes a linear spring, linear damper and Coulomb |
There was a problem hiding this comment.
The "Coulomb damper" was never implemented properly. Unless we intend to fix the implementation (which is not straightforward), I suggest disabling this functionality for now.
There was a problem hiding this comment.
The Coulomb damper is now removed from inputs and implementation.
| :math:`d_2 =z_n` and | ||
| :math:`d_3 =-y_n`. | ||
|
|
||
| The following (partial) list of coordinate systems are defined by ElastoDyn: |
There was a problem hiding this comment.
This section could be a bit misleading. The coordinate systems given here are a mixture of internal and external systems. I don't think you need these here, so, suggest deleting.
There was a problem hiding this comment.
I've now placed this in a "developer notes" section.
docs/source/user/aerodyn/input.rst
Outdated
| Comment | ||
| ====== General inputs ============================================================= | ||
| 1 TFinMod - Tail fin aerodynamics model {0: none, 1: polar-based, 2: USB-based} (switch) | ||
| 1.0 TFinArea - Tail fin planform area (m^2) [used only when TFinMod=1] |
There was a problem hiding this comment.
It looks like the model also needs TFinChord for the tail fin pitching moment calculation. Presumably this must be another input in the tail fin aerodynamics input file.
There was a problem hiding this comment.
That's correct, it was in the code but omitted in the documentation.
|
Thank you for your review, I've addressed your comments, choosing to remove the Coulomb damping, but keeping the user-defined subroutines. I'll merge this with latest dev and create a different pull request in the future to address the following:
|
This pull request is not ready to be merged
Feature or improvement description
Reactivate the rotor and tail furling option in OpenFAST.
AeroDyn:
ElastoDyn:
GlueCode:
Impacted areas of the software
AeroDyn/ElastoDyn/glue-code
Checklist
Work for a future pull request