Bug/bd conv #1482
Merged
Bug/bd conv #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using BeamDyn from OpenFAST, there was a convergence error during the initial correction steps which was not present when using the driver. After investigating, it turns out that the velocity in MiscVars%vvv was not being reinitialized in BD_InitACC during each correction and was accumulating offsets which caused the model to not converge. This commit adds the call to initialize the velocity which is present during the dynamic solve.
andrew-platt
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge.
Feature or improvement description
This pull request resolves an issue where the BeamDyn driver results were different from OpenFAST results. Specifically, OpenFAST failed to converge during initial correction steps whereas the driver succeeded because it didn't perform corrections. It was possible to make OpenFAST converge by specifying a smaller time step which is why the issue wasn't apparent. During the initial correction steps, the
MiscVarsvariablevvvwasn't being reset between steps which caused velocity errors to accumulate and the solution to diverge. This was corrected by re-initializingm%vvvinBD_InitAccwhich is only called during these initial correction steps.Related issue, if one exists
Impacted areas of the software
5MW_Land_BD_DLL_WTurbAdditional supporting information
Test results, if applicable
The
5MW_Land_BD_DLL_WTurbregression test results were updated because they were slightly different at the beginning of the simulation. A new test case,5MW_Land_BD_Initwas added to demonstrate that the model converges at a larger time step.