Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AeroDyn w/ Cavitation #15

Closed
wants to merge 41 commits into from
Closed

AeroDyn w/ Cavitation #15

wants to merge 41 commits into from

Conversation

robynnemurrayNREL
Copy link
Contributor

Updated the AeroDyn modules with a cavitation check, added input parameters, and included a verification for MHK turbines in the CertTest

If statement in ComputeSteadyAirfoilCoefs so that if there is no Cm data, Cpmin gets interpolated from IntAFCoefs(3)
Updated the BEMT_CalcOutputs to include a check for cavitation. Also included some checks for the cavitation input parameters here so that we don't waste time checking these if the user isn't doing a cavitation check.
Updated the BEMT_CalcOutputs to include a check for cavitation. Also included some checks for the cavitation input parameters here so that we don't waste time checking these if the user isn't doing a cavitation check.
@michaelasprague
Copy link
Contributor

@ghaymanNREL @robynnemurrayNREL , where are we with this pull request? I believe Greg requested a number of changes?

@sayerhs
Copy link
Contributor

sayerhs commented Apr 20, 2017

@robynnemurrayNREL, @ghaymanNREL Looking a the commit logs, the only thing I see that needs reverting is the addition of CertTests. The rest can be just squashed into one commit when merging the pull request. What's rationale for cherry picking through 41 commits?

@HaymanConsulting
Copy link
Contributor

duplicate. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants