-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AeroDyn w/ Cavitation #15
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If statement in ComputeSteadyAirfoilCoefs so that if there is no Cm data, Cpmin gets interpolated from IntAFCoefs(3)
Updated the BEMT_CalcOutputs to include a check for cavitation. Also included some checks for the cavitation input parameters here so that we don't waste time checking these if the user isn't doing a cavitation check.
Updated the BEMT_CalcOutputs to include a check for cavitation. Also included some checks for the cavitation input parameters here so that we don't waste time checking these if the user isn't doing a cavitation check.
@ghaymanNREL @robynnemurrayNREL , where are we with this pull request? I believe Greg requested a number of changes? |
@robynnemurrayNREL, @ghaymanNREL Looking a the commit logs, the only thing I see that needs reverting is the addition of CertTests. The rest can be just |
duplicate. closing |
ghost
mentioned this pull request
Apr 16, 2019
Closed
Closed
andrew-platt
referenced
this pull request
in andrew-platt/openfast
Dec 18, 2020
Platform pos for moordyn
mattEhall
referenced
this pull request
in mattEhall/openfast
Mar 23, 2021
FAST Farm infrastructure improvements
mattEhall
referenced
this pull request
in mattEhall/openfast
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the AeroDyn modules with a cavitation check, added input parameters, and included a verification for MHK turbines in the CertTest