Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TurbineType parameter #1610

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

hkross
Copy link
Contributor

@hkross hkross commented Jun 6, 2023

This pull request is ready to be merged.

Issue #1604 identified a couple of bugs in determining TurbineType. This parameter is used for the following:

  • a check that floating systems have a non-negative TowerBsHt in ElastoDyn
  • a check that AD14 doesn't use its tower influence model for floating systems (that model assumes the tower doesn't move from its initial position)
  • a check that offshore fixed and floating turbines use TurbinePos(3)=0 (for FAST.Farm)
  • printing to the OpenFAST summary file

Per discussion with @jjonkman, @andrew-platt, and @luwang00, it was determined that the TurbineType parameter and associated checks should be removed.

This pull request impacts the OpenFAST glue code. All existing r-tests pass and no new tests are required.

Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrew-platt andrew-platt self-assigned this Jun 12, 2023
@andrew-platt andrew-platt merged commit dade73d into OpenFAST:dev Jun 12, 2023
@hkross hkross deleted the bug/RemoveTurbineType branch June 15, 2023 20:19
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants