[BugFix] ServoDyn inputs for Lidar allocated twice, and a few other minor issues #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input arrays for Lidar to ServoDyn get allocated in ServoDyn.f90, and again in BladedInterface_EX.f90. This double allocation causes issues for many compilers. The logic behind all this really should be looked at in more detail, but since the Lidar module in InflowWind will be superceeded by LidarSim in release 4.0.0, I'm not going to sort the logic right now.
Affected arrays:
u%LidSpeed
u%MsrPositionsX
u%MsrPositionsY
u%MsrPositionsZ
Thanks to @foxton9 for reporting the issue, and proposing the fix!
andrew-platt
changed the title
|
Closes #1606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
Release v3.5.0 introduced a new Lidar capability into InflowWind. Just prior to release a few minor issues were fixed, but a double allocation also got introduced. This causes issues with most compilers.
Also fixed a couple minor issues with values getting set without allocation, and allocation to size 0.
Related issue, if one exists
#1606 reported by @foxton9
Impacted areas of the software
The Lidar module of OpenFAST should now function correctly.
Test results, if applicable
No test results are affected.