-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve Option 2 Performance enhancements #164
Conversation
Parts of the SolveOption2 algorithm have been moved to the the AdvanceStates routine so that BeamDyn, InflowWInd, AeroDyn, and ServoDyn use calculated inputs instead of extrapolations for inputs at t+dt. This change allows BeamDyn to use calculate rotations and AeroDyn/DBEMT to use calculated velocities, which otherwise would require a correction step. In DBEMT this was a problem with high turbulence and low wind speeds.
After chattting @ashesh2512, we should rerun a test with Some external collaborators have noted that the timestep must be really small. @bjonkman added the code in this PR to fix this issue at Envision. |
As expected, due to the slight changes in inputs, the regression tests fail. However, the results do not look much different than the baseline. These differences should be similar to the what is seen if you add a correction step to the models (particularly the onshore models). I would appreciate if this could be merged in the near future... it's been waiting more than a year. |
@bjonkman updated this doc with the AdvanceStates info: https://github.com/old-NWTC/FAST/blob/master/Docs/TheoryGuide/FAST_Algorithms/FAST_Algorithms_v8.tex Do we have a good place to migrate some of this info? |
We could add a |
Thanks, @rafmudaf and @andrew-platt! |
Parts of the SolveOption2 algorithm have been moved to the the AdvanceStates routine so that BeamDyn, InflowWind, AeroDyn, and ServoDyn use calculated inputs instead of extrapolations for inputs at t+dt.
This change allows BeamDyn to use calculated rotations and AeroDyn/DBEMT to use calculated velocities, which otherwise would require a correction step. In DBEMT this was a problem with high turbulence and low wind speeds.