[BuFix] InflowWind was not setting InitOut MWS data. #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing issues in the linearization as the reported windspeed was on the order of 1E+38, which did not format correctly in the `.lin` output file
deslaughter
reviewed
Jun 26, 2023
There was a problem hiding this comment.
@andrew-platt , I had intended to remove FileDat and pass InitOutData%WindFileInfo to the initialization functions instead, but I missed it. Could you make that change instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix is NOT ready for merging. Need to check if the
.linfiles in the regression tests are affected.Feature or improvement description
This fixes a bug in the reported windspeed from InfloWind to the glue code. The wind speed was getting set to
HUGE()which did not appear correctly in the.linfiles.Related issue, if one exists
#1622
Impacted areas of the software
Linearization was not reporting the correct wind speed in the
.linfiles.Test results, if applicable
The regression tests may need to be rerun as the reported wind speed in the.linfiles is0.0000 m/s. At the moment this doesn't make much sense to me since the reported value should beHUGE().The linearization regression tests are run without inflow.