Fix segfault in HD when no outputs specified #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where HydroDyn would segfault if no outputs were specified in the input file.
andrew-platt
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This commit fixes a bug where HydroDyn would segfault if no outputs were specified in the input file. This was caused by NumOutputs not being set for the Morison and Waves2 submodules if no outputs were specified. The segfault would occur when the OutList array was accessed with uninitialized NumOutputs variables.
This bug was been resolved in the
devbranch duringSeaStatedevelopment.Related issue, if one exists
#1863
Impacted areas of the software
HydroDyn_Input.f90