-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New spring element in SubDyn: 6 by 6 stiffness matrix #1889
New spring element in SubDyn: 6 by 6 stiffness matrix #1889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the code and it looks good to me. The r-test needs to be updated it seems
The changes to the SubDyn input files should be updated in the r-test repository. And likely some small documentation changes are needed. |
I have updated the documentation for this new spring element. I guess the current r-test will run just modifying the SubDyn input file accordingly. This is adding, below the RIGID LINK PROPERTIES section, the new entries:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few minor things. Overall it looks really good.
Members that are specified as spring elements (**MType=5**), | ||
have their properties defined in the spring element properties table. | ||
The table lists for each spring property: the property ID (**PropSetID**), the diagonal stiffness | ||
coefficients (**K11**, **K22**, **K33**, **K44**, **K55**, **K66**), and the cross-coupling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little confusing that the order of the coefficients listed here doesn't match the order in which they're specified in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description could be simplified by stating:
The table lists for each spring property: the property ID (**PropSetID**) and the stiffness coefficients (**K11**, **K12**, **K13**, **K14**, **K15**, **K16**, **K22**, **K23**, **K24**, **K25**, **K26**, **K33**, **K34**, **K35**, **K36**, **K44**, **K45**, **K46**, **K55**, **K56**, **K66**).
Like this it would appear in the same order as in the input file.
See PR RBergua#2 for updates (brings this PR up to dev -- only necessary to get r-test to the right point). |
Update to dev branch, and include regression test updates
SD springs: update r-test pointer
Will the spring elements be included in the next release of OpenFAST? And when is that coming? |
The spring elements for SubDyn have been merged into OpenFAST dev branch and will be available in OpenFAST v.4.0.0. Such OpenFAST version should be released relatively soon. |
I believe this pull request is ready to be merged.
Feature or improvement description
One new spring element has been included in SubDyn.
The spring is a new member type. Accordingly, SubDyn now supports as members: beams, cables, rigid elements and springs.
Previously, SubDyn could only include a stiffness matrix as a boundary condition.
The spring element has the next properties:
The new SubDyn input file includes a new section for the spring element. See below for reference:
Internally, the spring element relates 2 nodes with 6 DOFs each. Accordingly, mathematically the spring element has a 12 by 12 dimension.
Impacted areas of the software
Only SubDyn is impacted. Since this is a new element, the verification tests should pass as the legacy elements in the code have not been modified.
Additional supporting information
Having the capability to include a stiffness matrix is very helpful for modelers. This stiffness matrix can be used for example to model:
Test results, if applicable
Several test cases have been reviewed for the new spring element in SubDyn. Below some representative test cases are included. Results compare the output from SubDyn vs reference results (computed analytically or by means of different codes like HOTINT, SAMCEF and OpenModelica).
Checklist