Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsteady Aero Driver: adding 3 degrees of freedom for the motion of a genralized airfoil section #1910

Merged
merged 36 commits into from
Mar 11, 2024

Conversation

ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Dec 1, 2023

This pull request is soon ready to be merged

Feature or improvement description
Adding 3 degrees of freedom fro the motion of a genralized airfoil section

Impacted areas of the software
Unsteady Aerodynamics

Additional supporting information
A paper will be released at the torque 2024 conference. A link is provided in the documentation.

Test results, if applicable
Input file is backward compatible

  • Update the documentation - Live version here
  • Update r-test input files
  • Submit a new r-test for aeroelastic simulation will be done later after torque paper
  • Quick review

Example input file:
UA2.txt

ebranlard and others added 27 commits October 27, 2023 00:02
- vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type
- vs project needed LinDyn added to it
- moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn.
This would have caused issues when merging with the dev-unstable branch of OpenFAST
- update extension of UA output files
- explicitly initialize `d_34_to_ac`
* UA driver: vs build

- vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type
- vs project needed LinDyn added to it
- moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn.

* LinDyn: states should be reals, not logicals

This would have caused issues when merging with the dev-unstable branch of OpenFAST

* fix typo in RoutineName parameter

* UA: minor updates

- update extension of UA output files
- explicitly initialize `d_34_to_ac`
@ebranlard ebranlard changed the title Unsteady Aero Driver: adding 3 optional degree of freedom elastic system Unsteady Aero Driver: adding 3 degrees of freedom for the motion of a genralized airfoil section Dec 1, 2023
@ebranlard ebranlard changed the base branch from main to dev December 1, 2023 02:34
@ebranlard ebranlard marked this pull request as ready for review December 12, 2023 21:49
@andrew-platt
Copy link
Collaborator

andrew-platt commented Mar 7, 2024

Merge only after bugfix is merged in:

@andrew-platt andrew-platt changed the base branch from dev to dev-unstable-pointers March 11, 2024 18:41
@andrew-platt andrew-platt changed the base branch from dev-unstable-pointers to dev March 11, 2024 18:42
@andrew-platt
Copy link
Collaborator

I see the LynDyn module is new. Is that only used by the unsteady aero?

@bjonkman
Copy link
Contributor

I see the LynDyn module is new. Is that only used by the unsteady aero?

Yes. That is only used in the Unsteady Aero driver.

@andrew-platt andrew-platt self-assigned this Mar 11, 2024
@andrew-platt andrew-platt merged commit a2661d2 into OpenFAST:dev Mar 11, 2024
21 checks passed
@ebranlard ebranlard deleted the f/ua-elast-dev branch May 15, 2024 21:54
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants