Bug fix in allocating tower elevation array #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes a small bug in the TravisCI configuration and fixes issue #196. |
Closed
ashesh2512
pushed a commit
to ashesh2512/openfast
that referenced
this pull request
Mar 21, 2019
* Check for tower nodes before allocating data * Bug fix in the travis ci macos configuration * Resolve a merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves an array allocation into an if-statement which determines whether the array should be allocated.
The problem arises when
NumTwrNdsis not 0 in the input but this block at AeroDyn.f90L928 executes:This causes
InitOut%TwrElevto be allocated to an array of length 0 whileInputFileData%TwrElevis nonzero so this line at AeroDyn.f90L239 is a seg fault:All regression tests pass since none test this particular case.