HydroDyn: check for valid file unit before attempting to close #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonkman
approved these changes
Nov 27, 2018
|
@jjonkman good call, I've made that change. I'll merge after the automated tests complete. |
ashesh2512
pushed a commit
to ashesh2512/openfast
that referenced
this pull request
Mar 21, 2019
…AST#207) * Check for valid file unit before attempting to close * Use a more explicit if-statement condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning off
Hdsumin HydroDyn leads to a seg fault since HydroDyn tries to close a file which is not opened to begin with. This pull request checks for a valid file unit before attempting to close the HydroDyn summary file.This was reported at https://wind.nrel.gov/forum/wind/viewtopic.php?f=4&t=1111&start=15.