Remove ModVar from dev as ROCm Flang compiler can't build it. #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue will need to be resolved before OpenFAST 5.0 is released as it needs ModVar.f90
andrew-platt
approved these changes
Jun 6, 2024
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Jun 10, 2024
andrew-platt
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR remove the
ModVar.f90file which is being introduced as part of the tight coupling work, but is not yet being used in thedevbranch. This file uses the more modern Fortran 2003 which is not supported by the ROCm Flang compiler. Since this module isn't being used yet and is preventing OpenFAST from being built on Frontier, this code is being removed for now.Impacted areas of the software
NWTC Library
Additional supporting information
This issue will need to be resolved before OpenFAST 5.0 is released as it needs ModVar.f90