Skip to content

Conversation

@sanguinariojoe
Copy link
Contributor

@sanguinariojoe sanguinariojoe commented Jun 19, 2024

NOTE: The tests are failing because r-test dev branch is required. On my computer they seem to work (except the ones using aerodyn_inflow_library, see below)

Feature or improvement description
Now the latest version of pFUnit is considered, which allows to use Python >= 3.12

Impacted areas of the software
The tests framework

Additional supporting information
You are using a 10 years old pFUnit.

Test results, if applicable

The following tests FAILED:
         72 - py_ad_5MW_OC4Semi_WSt_WavesWN (Failed)
         73 - py_ad_B1n2_OLAF (Failed)
        102 - py_hd_5MW_OC4Semi_WSt_WavesWN (Failed)
        122 - py_ifw_turbsimff (Failed)
        133 - py_md_5MW_OC4Semi (Failed)

The error is always ModuleNotFoundError: No module named 'aerodyn_inflow_library'

@deslaughter
Copy link
Collaborator

@sanguinariojoe We really appreciate your pull request to update pFUnit so that it works with Python 3.12. However, we've been planning to move the unit testing to test-drive and remove the dependency on pFUnit. test-drive is fully Fortran based and doesn't use Python to generate the tests, which makes it simpler to add and debug unit tests. I expect the PR for the conversion to test-drive to be submitted and merged into dev within a couple of days. So, I'll leave this PR open until that gets merged and tested a bit. If test-drive doesn't work out, I'll be happy to merge your PR.

@deslaughter
Copy link
Collaborator

@sanguinariojoe The test-drive based unit test PR has been approved and merged (#2276). Closing this PR since we won't be using pFUnit going forward. Thanks again for your efforts in submitting this PR.

@sanguinariojoe
Copy link
Contributor Author

sanguinariojoe commented Jun 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants