Update to rotation matrix comments in NWTC Library#2310
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Jul 10, 2024
Merged
Update to rotation matrix comments in NWTC Library#2310andrew-platt merged 1 commit intoOpenFAST:devfrom
andrew-platt merged 1 commit intoOpenFAST:devfrom
Conversation
deslaughter
approved these changes
Jul 10, 2024
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
Based on the equations outlined in the comments, I agree that these are better described as Tait-Bryan angles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Updating the comments in the NWTC library for rotation matrices to reflect what is in the code. This caused some confusion in FloatingArrayDesign/MoorDyn#233 (comment)
Related issue, if one exists
n/a
Impacted areas of the software
NWTC library