Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross merge rc-3.5.4 to dev #2333

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Cross merge rc-3.5.4 to dev #2333

merged 14 commits into from
Jul 19, 2024

Commits on Apr 23, 2024

  1. Fix crash at exit when using new Intel icx compiler

    The new icx compiler is a bit smarter about checking for memory errors and a new one was discovered which causes OpenFAST to crap when calling MAP_End. The error is due to the OutputList nodes containing pointers to memory which has already been freed. This is due to the way the OutputList is constructed where nodes from other lists (containing pointers to string memory) were appended without allocating new memory. So when the original list was freed, these pointers became invalid, but then the OutputList tried to free them again, resulting in a double free error. To fix this issue, set_output_list was changed to allocate new memory for copies of these nodes.
    deslaughter committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c52e117 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f08226 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge pull request #2173 from deslaughter/b/MAP_free_outlist_crash

    Fix crash in MAP_End when using Intel's new icx compiler and disable caching in setup-python GH action
    andrew-platt authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2510bc2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    d46719a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    51b122e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2183 from mayankchetan/dockerDocs

    Update GHCR doc, remove old Dockerfile
    andrew-platt authored May 6, 2024
    Configuration menu
    Copy the full SHA
    c867e1a View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Add WEIS file readers and writers (#2188)

    * FEA: Add python package outline
    
    * REF: Rename python distribution/package to `openfast_python` / `openfast`
    
    * FEA: Move OpenFAST readers/writers over from WEIS
    
    * DEP: Add `pcrunch` dependency
    
    * REF: Update import paths from `weis` to `openfast`
    
    * DOC: Add contributors from WEIS to `authors` in `pyproject.toml`
    
    * DOC: Add brief explanation of `openfast` package to sub-readme
    
    * OPS: Fix format for authors names/emails
    
    * TST: Copy test from WEIS
    
    * OPS: Move `pyproject.toml` to top level
    
    * OPS: Publish `openfast` package to PyPI on release
    
    * TST: Add test data for `openfast` python package
    
    * REF: Remove extra python files
    
    * DOC: Adjust readme wording
    
    * DOC: Use link to specific git ref instead of `main` branch in readme
    
    * OPS: Add note about not relying on the `octue-openfast` package
    
    * OPS: Allow workflow dispatch of `deploy` workflow
    
    * WIP: Temporarily change name of python package
    
    * Deleting files related to running OpenFAST, Restructuring to be IO reading and writing only
    
    * setting ROSCO as optional, removing lin
    
    * updating the test files before move to r-test
    
    * removing rosco and pcrunch as deps
    
    * OpenFAST Output & Lin reader
    
    * Adding Oputput reader to test
    
    * Pointing test to one r-test case, removing test_data
    
    * Changing library name to openfast_io
    
    * OPS: Move poetry files into distribution root and rename package
    
    * REF: Rename package to `openfast_io`
    
    * DEP: Add `rosco` as optional dependency
    
    * DOC: Add installation instructions to python package readme
    
    * DOC: Fix docker commands for GHCR images
    
    * DOC: Add python package installation to docs
    
    * DOC: Update python package readme
    
    * WIP: Temporarily rename python package
    
    * OPS: Set working directory for python package build and publish
    
    * WIP: Temporarily change python package version
    
    * FIX: Update python package import paths
    
    * WIP: Increment temporary version number
    
    * replaced references to weis within code.
    
    * added Apache-2.0 license to pyproject.toml
    
    ---------
    
    Co-authored-by: Mayank Chetan <mayankchetan@gmail.com>
    cortadocodes and mayankchetan authored May 21, 2024
    Configuration menu
    Copy the full SHA
    397d1b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Always build openfastcpplib as shared. Use BUILD_OPENFAST_CPP_DRIVER …

    …to enable/disable openfastcpp so yaml-cpp isn't required for openfastcpplib
    deslaughter committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cef1e0b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2311 from deslaughter/f/cpp_api_driver_option

    Always build openfastcpplib as shared. Use BUILD_OPENFAST_CPP_DRIVER to disable openfastcpp executable
    andrew-platt authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d0f6154 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fix a couple of bugs in NWTC_IO.f90 which cause out of bounds array a…

    …ddressing or null pointer dereferencing
    
    - CountWords would scan past end of line
    - ProcessComFile Cleanup would dereference a null pointer when getting NextFile pointer
    - WrScr would hide a character string allocation which caused a memory issue in ifx
    deslaughter authored and andrew-platt committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    62b273e View commit details
    Browse the repository at this point in the history
  2. ED: set all values in RtHS to zero during allocation

    Some of these values were not getting zeroed out.  This was occasionally leading to spurious root acceleration values when memory that was previously occupied by something else non-zero was used.
    andrew-platt committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5f7b3c9 View commit details
    Browse the repository at this point in the history
  3. NWTC_IO: initialize all arrays created by AllocAry calls to zero

    Also moved the zeroing into the `else` part of the error checking instead of after -- we could potentially have triggered memory violations otherwise and not gotten our error back.
    andrew-platt committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    517640d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    6680158 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    40d16c4 View commit details
    Browse the repository at this point in the history