Bugfix for OpenFAST Registry incorrectly restoring pointers in modules with CObjs (ExtLd) #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR fixes a bug introduced in the new OpenFAST registry where the array pointers in modules which interopt with C code were not restored correctly after a restart. This bug was triggered when doing a restart in the C++ driver which simulates the AMR-Wind interface. Many thanks to @gantech for tracking down the exact issue (array indexing was off by 1), testing the fix, and creating a regression test.
This also uncovered a bug in setting the ExtLd wind velocity in
FAST_Solverwhich is resolved in this PR as well.A bug was corrected in
CTestList.cmakewhere C++ tests were added even when only building the API, not the driver. TheBUILD_OPENFAST_CPP_DRIVERhas been added around these tests so they will only be added when building the driver.A reference output file was added for the
5MW_Land_DLL_WTurb_cppregression test which was previously being run, but output wasn't being checked for correctness.Impacted areas of the software
5MW_Restart_cpp)Additional supporting information
Test results, if applicable
Added
5MW_Restart_cppregression test to check that restarts with C++ continue to work. No change in existing test results.