HD: Bug fix for potential-flow wave excitation with multiple bodies and large yaw offset #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd large yaw offset Two bugs are identified that lead to incorrect potential-flow wave excitation when multiple bodies are present with large yaw offset (PtfmRefY!=0): * When NBodyMod=1 and NBody>1, only the wave excitation on the first body is transformed back to the inertial frame in WAMIT_Init. * When PtfmRefY!=0 with PtfmRefxt or PtfmRefyt being nonzero, there is effectively a displacement of each potential-flow body due to platform yaw offset when precomputing the wave excitation each body. In other words, the effect of this baseline displacement is already baked into the precomputed wave excitation, so it needs to be subtracted from the total body displacement when interpolating the wave excitation in WAMIT_CalcOutput if ExctnDisp>0.
andrew-platt
approved these changes
Sep 9, 2024
|
Related to #2203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Two bugs were identified that led to incorrect potential-flow wave excitation when multiple bodies are present with large yaw offset (
PtfmRefY!=0orPtfmYMod=1):When
NBodyMod=1andNBody>1, only the wave excitation on the first body is transformed back to the inertial frame. This PR adds the transformation of the subsequent bodies.When
PtfmRefxt!=0orPtfmRefyt!=0, there is effectively a displacement of each potential-flow body due to platform yaw offset when precomputing the wave excitation. In other words, the effect of this baseline displacement is already baked into the precomputed wave excitation, so it needs to be subtracted from the total body displacement when interpolating the wave excitation ifExctnDisp>0. This correction is implemented in this PR.Impacted areas of the software
HydroDyn
Test results, if applicable
Existing tests are not impacted by the bugs identified, so no change to the test results.