DBEMT_Mod = -1 for linearization #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBEMT_Init wasn't getting called
bjonkman
reviewed
Sep 18, 2024
| @@ -636,7 +636,7 @@ subroutine BEMT_Init( InitInp, u, p, x, xd, z, OtherState, AFInfo, y, misc, Inte | |||
| if (errStat >= AbortErrLev) return | |||
|
|
|||
| InitInp_DBEMT%DBEMT_Mod = p%DBEMT_Mod | |||
| if ( p%DBEMT_Mod > DBEMT_none ) then | |||
| if ( p%DBEMT_Mod > DBEMT_none .or. p%DBEMT_Mod == DBEMT_Frozen ) then | |||
There was a problem hiding this comment.
maybe this should be rewritten as if ( p%DBEMT_Mod /= DBEMT_none) then
There was a problem hiding this comment.
Actually... Are you sure the DBEMT module is supposed to be called with frozen wake? I thought it just called a routine in BEMT instead of the DBEMT module.
There was a problem hiding this comment.
I'm thinking the places where we check p%DBEMT_Mod /= DBEMT_none should be changed to p%DBEMT_Mod > DBEMT_none to avoid the seg fault you were seeing.
There was a problem hiding this comment.
It seems we need DBEMT_Init to get called, otherwise we get a seg fault. But perhaps I addressed the wrong issue with that change. I'll revisit this again shortly (probably another PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Aero linearization should be possible with
DBEMT_Modset to-1(frozen wake)Related issue, if one exists
The
FrozenWakeflag was merged into theDBEMT_Modoptions in PR #1909Impacted areas of the software
Linearization with frozen wake was not possible