Fix path to installed MAP include files #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #2435 |
andrew-platt
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
PR #2392 added support for installing the MAP header files; however, the location of the installed files in
$<INSTALL_INTERFACE:*>weren't specified correctly. This caused CMake to generate an error about the header files not being found when importing the library in Nalu-Wind (#2435). This PR corrects the path specified via$<INSTALL_INTERFACE:*>. This PR has been verified to fix the issue during a Nalu-Wind compilation.Impacted areas of the software
MAP++'s CMakeList.txt