Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtInfw: relocate initialization to after AD_Init #2445

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

andrew-platt
Copy link
Collaborator

Ready to merge

Feature or improvement description
At some point we moved IfW_Init and ExtInfw_Init to before AD_Init. This works for IfW (allows passing wind data pointer directly to AD_Init), but does not work for ExtInfw_Init which requires a bunch of AD InitOut data as output.

Related issue, if one exists

Impacted areas of the software
Using ExtInfw with AMR-Wind was giving seg-faults.

Additional supporting information

Test results, if applicable
This should not affect any test restults.

@marchdf, could you test this?

At some point we moved IfW_Init and ExtInfw_Init to before AD_Init.  This works for IfW (allows passing wind data pointer directly to AD_Init), but does not work for ExtInfw_Init which requires a bunch of AD InitOut data as output.
@deslaughter deslaughter merged commit 4da8b4e into OpenFAST:dev Oct 1, 2024
41 of 42 checks passed
@andrew-platt andrew-platt deleted the b/ExtInfw_Init branch November 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants