ExtInfw: relocate initialization to after AD_Init #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point we moved IfW_Init and ExtInfw_Init to before AD_Init. This works for IfW (allows passing wind data pointer directly to AD_Init), but does not work for ExtInfw_Init which requires a bunch of AD InitOut data as output.
deslaughter
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
At some point we moved IfW_Init and ExtInfw_Init to before AD_Init. This works for IfW (allows passing wind data pointer directly to AD_Init), but does not work for ExtInfw_Init which requires a bunch of AD InitOut data as output.
Related issue, if one exists
Impacted areas of the software
Using
ExtInfwwith AMR-Wind was giving seg-faults.Additional supporting information
Test results, if applicable
This should not affect any test restults.
@marchdf, could you test this?