AD bugfix: Segmentation fault with ifx #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OLAF was used with the AeroDyn Driver compiled with ifx (IFX) 2023.2.0 20230622 (release only), there would be a segmentation fault when SetInputsForFVW was called. The root issue was that passing an array of `u` as `(/u/)` doesn't work correctly with this compiler. So to work around this, the SetInputsForFVW routine was reworked to only operate on a single `u`. In my opinion this is a hack of a solution to accomodate a compiler bug.
|
I think it’s actually a good fix as that syntax was dynamically creating an
array and copying u into it at every call, which is probably why it caused
a segfault. If something in u can’t be directly copied, then it could be
doing anything.
…On Thu, Nov 14, 2024 at 6:59 PM Andy Platt ***@***.***> wrote:
@andrew-platt <https://github.com/andrew-platt> requested your review on:
#2516 <#2516> AD bugfix:
Segmentation fault with ifx.
—
Reply to this email directly, view it on GitHub
<#2516 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCSATLNXYIODPCQCTQLSCL2AU2OXAVCNFSM6AAAAABR2BOZECVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGMYDKNRWGIZTCNA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
That's probably the issue: something in |
deslaughter
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge, unless someone has a more elegant solution
Feature or improvement description
When OLAF was used with the AeroDyn Driver compiled with ifx (IFX) 2023.2.0 20230622 (release only), there would be a segmentation fault when SetInputsForFVW was called. The root issue was that passing an array of
uas(/u/)doesn't work correctly with this compiler. So to work around this, the SetInputsForFVW routine was reworked to only operate on a singleu.In my opinion this is a hack of a solution to accomodate a compiler bug.
Related issue, if one exists
none
Impacted areas of the software
AeroDyn driver, only when compiled with ifx
Additional supporting information
Test results, if applicable
This would trigger a segmentation fault in the
ad_HelicalWakeInf_OLAFin 3.5.5 with ifx (IFX) 2023.2.0 20230622 in release.