Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero padding of VTK names, and log10 of zero (see #250) #257

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Zero padding of VTK names, and log10 of zero (see #250) #257

merged 2 commits into from
Mar 18, 2019

Conversation

ebranlard
Copy link
Contributor

THIS PULL REQUEST IS READY TO MERGE

Related issue, if one exists

Fixes #250

Impacted areas of the software

openfast-library, file FAST_Subs

@rafmudaf rafmudaf self-assigned this Mar 7, 2019
@ebranlard ebranlard mentioned this pull request Mar 8, 2019
Closed
@ebranlard
Copy link
Contributor Author

This revised pull request should now address the two issues mentioned in #250. The second one concerns the variable twidth which was wrongly set, as mentioned by @bjonkman in #172.

I believe it's ready to merge, it implements the solution discussed in #250.

@ebranlard ebranlard changed the title Fixed error when NOutSteps is 0 (see #250) Fixed zero padding of VTK names, and error related to log10 of zero (see #250) Mar 12, 2019
@ebranlard ebranlard changed the title Fixed zero padding of VTK names, and error related to log10 of zero (see #250) Zero padding of VTK names, and log10 of zero (see #250) Mar 12, 2019
@rafmudaf rafmudaf self-requested a review March 18, 2019 22:13
rafmudaf
rafmudaf approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@rafmudaf rafmudaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rafmudaf rafmudaf merged commit 677fe77 into OpenFAST:dev Mar 18, 2019
@ebranlard ebranlard deleted the feature/issue250b branch October 24, 2019 16:54
@andrew-platt andrew-platt mentioned this pull request Aug 6, 2021
Merged
3 tasks
@AnitaLeite
Copy link

Hello! I'm trying the visualization tool for the first time on OpenFast v3.1 and the following error shows up: 'FAST_InitializeAll:HydroDyn_Init: WaveElevSeries arrays for first and second order wave elevations are of different sizes.'
I'm running for irregular waves with AeroDyn and Inflow disabled and using Volturn-US semi-sub model.

I was checking this conversation for a solution and this was flagged in 2019. Is there a solution for this please? I thought that if the problem was on FAST_subs.f90 that the binaries for my version were already updated?

Thank you!

Anita

@jjonkman
Copy link
Collaborator

Dear @AnitaLeite,

It looks like this error was reported recently--see: #1484. I'm not aware if this has been debugged yet.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafmudaf rafmudaf rafmudaf approved these changes

Assignees

@rafmudaf rafmudaf

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ebranlard @AnitaLeite @jjonkman @rafmudaf