[BugFix] OMP critical names preventing Intel+OMP compilation #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `!$OMP critical(fileopen)` statements to `!$OMP critical(fileopen_critical)` and fix a few misnamed critical statements A `!$OMP critical(filename)` in AD was causing Intel to fail to compile with OMP enabled due to `filename` being used as a variable in the same routine (GCC didn't care)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Change the
!$OMP critical(fileopen)statements to!$OMP critical(fileopen_critical)and fix a few misnamed critical statementsA
!$OMP critical(filename)in AD was causing Intel to fail to compile with OMP enabled due tofilenamebeing used as a variable in the same routine (GCC didn't care)Related issue, if one exists
After the release of 4.0.0, it was discovered that Intel compilers could not compile with
OMPenabled.Impacted areas of the software
Compilation using Intel and OpenMP only.
Test results, if applicable
No changes