Windows VS build -- stack overflow with FAST.Farm #2607
Merged
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
We have had issues with stack overflows with FAST.Farm using VS + Intel compiled FF on Windows. This is the latest round of trying to address the issue.
Related issue, if one exists
#2452 -- previous attempt at fixing this issue
#2604 -- latest bug report on the issue for v4.0.0
Impacted areas of the software
Memory allocation for FAST.Farm built on Windows using VS + Intel.
Additional supporting information
In #2452, we added
/heap-arrays:1000to set all arrays allocated larger than 1 Kb to be on the heap. However, according to the last comment on this post: https://community.intel.com/t5/Intel-Fortran-Compiler/memory-usage/m-p/1137047/highlight/true, this doesn't necessarily work as intended. So we are setting it to0as recommended, and also increasing the stack size by 10x.Test results, if applicable
No tests are affected.