Cleanup LIDAR code #2761
Merged
Cleanup LIDAR code #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `NumPulseGate` and `NumBeam` consistently so we can cleanup some of the IF statement in the code - don't allow pulsed lidars to have 0 gates - remove unused lidar states - updated computation of `MsrPositionsY` and `MsrPositionsZ` for pulsed lidar. Previous calculations didn't make any sense to me
- move all lidar parameter initialization into lidar_init - remove unused lidar_initInput values and move the one that is used into InflowWind initInput - remove unused variables - check that lidar arrays are allocated before initializing them (before call to SrvD_Init and before reading from IfW file) - move logic to check number of beams allowed into lidar module and only make sure the value is at least 1 before allocating so beam focal distances can be read/parsed with valid arrays sizes - make ConsiderHubMotion an integer again since I don't want to change the input files
- remove unnecessary lidar allocatable arrays in SrvoDyn InitInp type - remove unused URefLid from ServoDyn InitInp; the value that is passed to the controller was never initialized and doesn't make sense for a controller to use anyway. - allocate lidar arrays for controller based on number of beams and pulse gates instead of type of lidar - initialize error status in BladedInterface_End routine
deslaughter
approved these changes
Apr 23, 2025
| ! is used until after AD_Init below). | ||
| InitInData%BoxExceedAllow = .true. | ||
|
|
||
| !bjj: what about these initialization inputs? |
Collaborator
There was a problem hiding this comment.
Good question. I don't know offhand. Thanks for adding the comment -- hopefully we get around to addressing it a some point.
andrew-platt
approved these changes
Apr 24, 2025
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for fixing issues here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
A recent review of LIDAR capability in OpenFAST, revealed some improvements that could be made. This pull request cleans up some of the implemented LIDAR code.
NumPulseGateandNumBeamconsistently so we can cleanup some of the IF statements in the codeMsrPositionsYandMsrPositionsZfor pulsed lidar. Previous calculations didn't make any sense to me.Related issue, if one exists
Impacted areas of the software
LIDAR only
Additional supporting information
Test results, if applicable
This does not change any existing regression tests.