Docs: correct Bladed Interface channel 63 description #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonkman
reviewed
May 6, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
I agree with the wording change, but the arrow direction should still be "<--" as this data is passed to OpenFAST from the DISCON controller.
Collaborator
Author
|
The code and the Bladed document both indicate record 63 is passed from SrvD to the DLL. Am I misreading this? |
jjonkman
approved these changes
May 6, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
My bad; I misread the code! You are right.
This was referenced Jun 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The description for the
avrSWAParray record 63 was incorrect. This was reflected both in the documentation on readthedocs.org and in the summary file generated by ServoDyn. The internal code was correct.Original:
63 <-- Number logging channelsCorrected:
63 --> Record number for start of logging output (-) [set to ###]Related issue, if one exists
Reported internally
Impacted areas of the software
Documentation only.
Consider for backporting to 4.0.5