Update Visual Studio compile settings for C Binding interfaces #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
approved these changes
Jul 21, 2025
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
I'll run the GH action to test this change
Collaborator
Author
|
Oh I didn't realize there was an actions job set up for the visual studio project. I don't see anything related in |
andrew-platt
force-pushed
the
VS-compile-settings
branch
2 times, most recently
from
03589b6 to
9d3e1b3
Compare
ifort compiler needs arguments for sizing later arguments to be first
andrew-platt
force-pushed
the
VS-compile-settings
branch
from
9d3e1b3 to
94f8529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align C Binding Interface Visual Studio compile settings
This pull request updates the Visual Studio compiler settings for the C Binding interface targets fixing a potential memory leak described in #2613. This change aligns the compilers settings for these interfaces with FAST Farm and FAST Library (#2732).
Note that I have not tested this since I don't have a Windows computer. @andrew-platt I'll defer to you on how to validate this change.