FAST.Farm: skip writing invalid VTK slices #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior: fatal error if outside grid New behavior: skip that slice, keep number of slices the same as input file request How: new array of logicals for `valid` slice. Cycle on invalid slices
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies FAST.Farm's VTK slice writing functionality to gracefully handle invalid slice requests instead of causing fatal errors. When terrain is present, it becomes less obvious during setup whether a requested slice location is valid within the grid boundaries.
Key changes:
- Adds validity tracking arrays for each slice type (XY, YZ, XZ planes)
- Changes fatal errors to warnings when slices fall outside the grid
- Implements slice skipping logic during output generation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AWAE_Types.f90 | Adds three new boolean arrays to track slice validity and implements corresponding memory management |
| AWAE_Registry.txt | Registers the new validity tracking arrays in the parameter type definitions |
| AWAE.f90 | Implements validation logic during initialization and skip logic during output generation |
jjonkman
approved these changes
Aug 7, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
I approve of this change after you fix the comment Copilot noted is in error (Change XZ to YZ).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jjonkman
approved these changes
Aug 8, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Thanks for fixing this typo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Old behavior: fatal error if outside grid
New behavior: skip that slice, keep number of slices the same as input file request
How: new array of logicals for
validslice. Cycle on invalid slicesRelated issue, if one exists
#2951
Impacted areas of the software
FAST.Farm vtk slice writing only
Additional supporting information
With terrain, it gets a little less obvious if a requested slice is actually valid during preliminary setup. @rthedin requested this feature.
Test results, if applicable
No test results change