FASTlib: missing error handling on FAST_CFD_WriteOutput #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could create issues for FSI coupling. Noticed this in compilation warnings.. Consider backporting: - backport to v4.0.7 (if we do one) - backport to v4.1.3 (if we do one)
deslaughter
approved these changes
Aug 15, 2025
Collaborator
|
Thanks for finding this, I'm sure it would have caused issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
This could create issues for FSI coupling. Noticed this in compilation warnings.
Consider backporting:
Related issue, if one exists
None
Impacted areas of the software
CFD coupling from AMR-Wind / NALU-Wind for FSI
Test results, if applicable
No test results affected