Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update to the existing documentation #341

Merged
merged 23 commits into from
Nov 6, 2019

Conversation

rafmudaf
Copy link
Collaborator

@rafmudaf rafmudaf commented Oct 1, 2019

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE.

Feature or improvement description
This pull request provides a major update to the online documentation in the form of general tidying and cleanup plus some restructuring of the layout and organization. All sections were modified except the user guide which will be updated in a subsequent pull request.

Installation

  • The Getting Started section was removed and incorporated into this section as it was mostly redundant
  • A higher level structure was added
  • The availability of precompiled binaries for Windows is made more explicit and clear
  • The CygWin compile instructions have been removed Lets discuss this in the comments
  • A deeper explanation of CMake is provided

Testing
This is all structurally the same, but the content has been cleaned up and improved. Better examples for running the regression test are given.

Developer Guide

  • The Doxygen API reference is enabled (it was previously off)
  • Subsections were cleaned up and content updated

Sections yet to be improved:

Related issue, if one exists
None

Impacted areas of the software
Documentation

Test results, if applicable
A live version of these updates is available at: https://raf-openfast.readthedocs.io/en/docs-general_updates/

@rafmudaf
Copy link
Collaborator Author

@andrew-platt @ashesh2512 Could you take a look at the changes here and provide some feedback?

@rafmudaf rafmudaf force-pushed the docs/general_updates branch from 45b6a28 to fa52157 Compare October 29, 2019 22:35
@rafmudaf rafmudaf force-pushed the docs/general_updates branch from fa52157 to b469487 Compare October 30, 2019 21:55
@rafmudaf
Copy link
Collaborator Author

rafmudaf commented Nov 6, 2019

Hearing no objections, I'm going to merge this pull request today.
@michaelasprague @jjonkman have you had a chance to look at it?
@bjonkman any further feedback?

@bjonkman
Copy link
Contributor

bjonkman commented Nov 6, 2019

@rafmudaf , I haven't had time to read much of this and probably won't have time any time soon. I don't have any objections to you merging it.

@andrew-platt
Copy link
Collaborator

I have no objections to merging it.

There are a few items related to BeamDyn that need updating. I will include those in the BeamDyn PR.

@rafmudaf
Copy link
Collaborator Author

rafmudaf commented Nov 6, 2019

Ok, sounds good. This pull request does not change the user documentation, but I have some other ones coming regarding that portion of the docs.

@rafmudaf rafmudaf merged commit 33a4f84 into OpenFAST:dev Nov 6, 2019
@rafmudaf rafmudaf deleted the docs/general_updates branch November 6, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants