-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Findloc in SubDyn #356
Conversation
There is a subroutine interface However, given that |
Thanks for the feedback, I'll try to see if I can use |
I'd like to use |
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
An important part of the discretization routine
SD_Discrt
is used to reindex the user inputs from "IDs" to indices. This involved several lookup of indexes in arrays. This was previously done by copying pasting several time the same code ("while loops").I've added a function
findloci
, which is a simplified version of the fortran intrisincfindloc
(which is not yet available on all compilers), and used this instead of the copy-pasted while loops.I've also isolated the code that performs the reindexing since it doesn't really belong to the discretization routine.
I'm committing this now to limit the differencess with my other branch
f/flexsub2
Related issue, if one exists
Follow up of #351
Impacted areas of the software
SubDyn module