Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp library gluecode #36

Merged
15 commits merged into from
Aug 9, 2017
Merged

Cpp library gluecode #36

15 commits merged into from
Aug 9, 2017

Conversation

gantech
Copy link
Collaborator

@gantech gantech commented Jul 24, 2017

Improving robustness in C++ API and including installation instructions and sample installation and configuration scripts.

@gantech gantech requested review from sayerhs and jrood-nrel July 24, 2017 23:15
@gantech
Copy link
Collaborator Author

gantech commented Jul 24, 2017

@sayerhs The spack based config script doesn't quite work with linking to the hdf5 libraries. Could you please help with this issue when you get the time. @jrood-nrel is quite familiar with my frustrations on this issue.

@sayerhs
FAST CXX: Update CMake directives for Spack HDF5 compilation
592c15e 
Spack's HDF5 doesn't use a CMake configuration file, so the dependencies on
zlib and libxml2 are set correctly when compiling the `openfastcpp`
executable. The update specifically adds these dependencies to ensure
compilation under both autoconf and CMake builds of HDF5.
@sayerhs
Copy link
Contributor

sayerhs commented Jul 25, 2017

@gantech I have added a new commit to your cppLibraryGlueCode that should fix the linking issue when building OpenFAST against spack installed libraries. Also see the corresponding update to the NaluSpack master branch that will allow you to do spack install openfast@develop+cxx and get all dependencies in one shot.

==> Installing openfast
==> cmake is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/cmake-3.8.0-b753mbz7v5bodrfoodnq6pjejz7ehdsk
==> hdf5 is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/hdf5-1.8.16-ee2nsbowdrvy4npv6kvjlnjz4rcphoxp
==> libxml2 is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/libxml2-2.9.4-hlegrasbrhpmm3mnitrv7jztvhai4ysb
==> zlib is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/zlib-1.2.11-dayoxcvooeyba7urrdphgeqd7gr6h7xr
==> openmpi is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/openmpi-1.10.3-gp6gqlvjm25kf5n46ib5jkv3mfse377a
==> yaml-cpp is already installed in /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/yaml-cpp-0.5.3-jfzt747wz5mlc37lx6pdsiqi6tlor5uf
==> netlib-lapack is externally installed in /usr/lib64
==> Already fetched /home/sanantha/spack/var/spack/stage/openfast-develop-jedvy5ya5bdgtacr4uv7r74atyxqi5r4/openfast
==> No checksum needed when fetching with git
==> Already staged openfast-develop-jedvy5ya5bdgtacr4uv7r74atyxqi5r4 in /home/sanantha/spack/var/spack/stage/openfast-develop-jedvy5ya5bdgtacr4uv7r74atyxqi5r4
==> Already patched openfast
==> Building openfast [CMakePackage]
==> Executing phase : 'cmake'
==> Executing phase : 'build'
==> Executing phase : 'install'
==> Successfully installed openfast
  Fetch: 0.00s.  Build: 13.99s.  Total: 14.00s.
[+] /home/sanantha/spack/opt/spack/linux-centos6-x86_64/gcc-5.2.0/openfast-develop-jedvy5ya5bdgtacr4uv7r74atyxqi5r4

jrood-nrel
jrood-nrel approved these changes Jul 25, 2017
View reviewed changes
Copy link
Collaborator

@jrood-nrel jrood-nrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine with me @gantech . Thanks @sayerhs .

sayerhs
sayerhs approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@sayerhs sayerhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend independent testing of build process against Peregrine shared Spack installation before merging with dev.

@gantech gantech requested a review from a user August 7, 2017 19:47
@gantech
Copy link
Collaborator Author

gantech commented Aug 7, 2017

@rafaelmudafort and @sayerhs I updated the installation instructions. Could you provide some feedback on this. I mostly copied them from @jrood-nrel's instructions for Nalu.

gantech
gantech commented Aug 8, 2017
View reviewed changes
docs/source/install_linux.rst Outdated
@@ -51,11 +51,10 @@ Step 1
~~~~~~

This assumes you have a Homebrew installation of GCC installed already
(we are using GCC 6.3.0). These instructions have been tested on OSX 10.11. MacOS 10.12
will not build CMake with GCC anymore, so these instructions won't work
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @rafaelmudafort for pointing this line out. I'm not sure about this. Hence I'm taking this out.

@gantech
Copy link
Collaborator Author

gantech commented Aug 9, 2017

Thanks for all the modifications to the installation instructions @rafaelmudafort. Could we merge this into dev then?

@ghost ghost merged commit cdcdc2f into OpenFAST:dev Aug 9, 2017
@gantech gantech deleted the cppLibraryGluecode branch June 25, 2018 12:17
@ghost ghost mentioned this pull request Apr 16, 2019
Closed
@CallumG-Ed CallumG-Ed mentioned this pull request Jan 24, 2020
Closed
@caroledaniel caroledaniel mentioned this pull request Feb 27, 2020
Closed
@AtilaOnaya AtilaOnaya mentioned this pull request Apr 10, 2020
Closed
@HYFOAM HYFOAM mentioned this pull request Nov 29, 2020
Closed
@Christophe-delFosse Christophe-delFosse mentioned this pull request Apr 8, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayerhs sayerhs sayerhs approved these changes

@jrood-nrel jrood-nrel jrood-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gantech @sayerhs @jrood-nrel @rafmudaf