Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beamdyn and orcaflex updates #38

Closed
wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2017

This pull request updates beamdyn_driver and orcaflex_driver with handling for single precision builds. Currently, building in single precision causes compiler errors in these two module drivers due to type mismatches.

Also in this pull request is an update to BD_CrvExtractCrv which improves upon the arithmetic set up in #31.

All of the BeamDyn updates were adapted from @bjonkman's fork at f/Envision-BeamDyn.

The regression test completed with these results:

96% tests passed, 1 tests failed out of 27

Label Time Summary:
aerodyn14     = 3145.73 sec (7 tests)
aerodyn15     = 14563.32 sec (19 tests)
beamdyn       = 1359.88 sec (2 tests)
elastodyn     = 16350.83 sec (25 tests)
hydrodyn      = 8735.51 sec (7 tests)
map           = 1403.95 sec (3 tests)
moordyn       = 841.59 sec (1 test)
openfast      = 17709.05 sec (26 tests)
regression    =   1.67 sec (1 test)
servodyn      = 17697.20 sec (25 tests)
subdyn        = 6489.97 sec (3 tests)

Total Test time (real) = 3388.56 sec

The following tests FAILED:
	 26 - 5MW_Land_BD_DLL_WTurb (Failed)
Errors while running CTest

It is expected that the test case running BeamDyn would have very small changes in the solution. Further investigation reveals that the three failing channels contained negligible differences in the solutions:

b1rootfyr
twrbsfxt
twrbsmzt

…r was defined relative to the working directory instead of the directory where the driver input file is located
This forces the use of double over float when compiling in single precision
…bust arithmetic

4 sets of equations should give same results, assuming the "pivot" is not zero. New implementation picks set of equations with largest pivot value, not just one that is slightly larger than 0. (The values are all bounded by 0 and 4 [or less].)
@ghost ghost changed the base branch from master to dev July 28, 2017 05:17
@ghost ghost self-assigned this Jul 28, 2017
@ghost ghost requested review from HaymanConsulting and removed request for HaymanConsulting July 28, 2017 17:48
@rafmudaf
Copy link
Collaborator

rafmudaf commented Aug 4, 2017

I'm closing this pull request without merge as these changes will be included in a subsequent pull request

@ghost ghost closed this Aug 4, 2017
@ghost ghost deleted the feature/beamdyn-updates branch August 7, 2017 17:18
@HYFOAM HYFOAM mentioned this pull request Nov 29, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant