Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory memory leak during shutdown #410

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix memory memory leak during shutdown #410

merged 1 commit into from
Mar 11, 2020

Conversation

psakievich
Copy link
Contributor

  • Deallocate Turbine data when shutting down
  • Verified by running openfast in gtest in multiple unittests

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE

Fix memory memory leak during shutdown
e523d03 
 - Deallocate Turbine data when shutting down
 - Verified by running openfast in gtest in multiple unittests
@sayerhs sayerhs requested a review from gantech March 11, 2020 15:11
gantech
gantech approved these changes Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@gantech gantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We had called FAST_End for each turbine but never deallocated the Turbine array itself. This is helpful.

@andrew-platt andrew-platt merged commit ded607e into OpenFAST:dev Mar 11, 2020
@rafmudaf rafmudaf mentioned this pull request Apr 2, 2020
Merged
@rafmudaf rafmudaf self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantech gantech gantech approved these changes

Assignees

@rafmudaf rafmudaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psakievich @gantech @andrew-platt @rafmudaf